[No QA] Upgrade Node to 26.5.0 and npm to 11.17.0#96205
Draft
NicolasBonet wants to merge 8 commits into
Draft
Conversation
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This reverts commit b639c1a.
Codecov Report✅ All modified and coverable lines are covered by tests. |
Node 26 applies the nearest package.json "type" to extensionless files, so requiring the extensionless yargs/yargs file (package has type: module) now fails in ESM scope. The patch points the ./yargs subpath require condition at a .cjs copy.
HybridApp builds couple App and Mobile-Expensify: App CI builds from the Mobile-Expensify submodule and Mobile-Expensify CI installs App from main, so exact engine pins on either side cannot merge in any order. Both repos accept both versions until the upgrade lands everywhere, then a follow-up tightens the pins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Upgrades Node from 20.20.2 to 26.5.0 and npm from 10.8.2 to 11.17.0 (the npm version bundled with Node 26.5.0, so
nvm usegives the right npm with no extra steps), as part of a coordinated Node 26 upgrade across all Expensify repos.Changes:
.nvmrcandpackage.jsonengines bumped to Node 26.5.0 / npm 11.17.0.package-lock.jsonregenerated with npm 11. The previous lock was missing the@img/sharp-*platform-specific optional dependency entries, which npm 11's stricternpm cisync validation rejects; regenerating restores them.No runtime code changes — build/tooling only.
Fixed Issues
$
PROPOSAL:
MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14015
Tests
nvm install 26.5.0 && nvm use 26.5.0.npm ciand verify it completes without errors.npm run typecheck-tsgoand verify it passes.npx jest tests/unitand verify results matchmain(20 pre-existing date-related failures occur identically on Node 20.20.2 and are unrelated to this change).Offline tests
None — tooling-only change with no runtime behavior.
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
No UI change — tooling only.
Android: mWeb Chrome
No UI change — tooling only.
iOS: Native
No UI change — tooling only.
iOS: mWeb Safari
No UI change — tooling only.
MacOS: Chrome / Safari
No UI change — tooling only.